rnk marked an inline comment as done. rnk added inline comments.
================ Comment at: clang/lib/CodeGen/MicrosoftCXXABI.cpp:1349 + // the base dtor is emitted. + // FIXME: To match MSVC, this should only be done when the class was + // dllexported inlines are being exported. ---------------- hans wrote: > The grammar looks funny here: "when the class was dllexported inlines are > being exported". Thanks, too much editing leads to mistakes. =/ Cleaned up to: // FIXME: To match MSVC, this should only be done when the class is exported // with -fdllexport-inlines enabled. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70931/new/ https://reviews.llvm.org/D70931 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
