ABataev added inline comments.
================ Comment at: clang/lib/Sema/SemaOpenMP.cpp:4374 + case DMIB_unspecified: + return OMPC_MAP_tofrom; + } ---------------- cchen wrote: > ABataev wrote: > > `OMPC_MAP_tofrom` must be returned only for `DMIB_tofrom`, for others, it > > must be `llvm_unreachable(....)` > For DMIB_firstprivate, I think you are right, it should be unreachable, > however, for DMIB_default and DMIB_unspecified, they are definitely reachable > in `ActOnOpenMPExecutableDirective`. Then this function is not correct because for scalars default is not tofrom. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69204/new/ https://reviews.llvm.org/D69204 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
