Re: [PATCH] D16517: ClangTidy check to flag uninitialized builtin and pointer fields.

[Felix Berger via cfe-commits]

flx added inline comments.

================
Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:205
@@ +204,3 @@
+      Diag << FixItHint::CreateInsertion(
+          Field->getSourceRange().getEnd().getLocWithOffset(
+              Field->getName().size()),
----------------
alexfh wrote:
> Maybe Lexer::getLocForEndOfToken?
Tried:

    Lexer::getLocForEndOfToken(Field->getSourceRange().getEnd(),
                                     Field->getName().size(),
                                     Result.Context->getSourceManager(),
                                     Result.Context->getLangOpts()),

but that placed the {} before the field name:

-  bool G /* with comment */;
+  bool {}G /* with comment */;
 




http://reviews.llvm.org/D16517



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits