Mostly that you didn't mention it in your commit message. I'd rather prefer the rest of the file be changed to match the __ rather than the other way around :)
-eric On Wed, Feb 10, 2016 at 4:14 PM Romanova, Katya < katya_roman...@playstation.sony.com> wrote: > Hi Eric, > > Everywhere else in this file formal parameter “a” is used. This one “__a” > was inconsistent. > > However, if you don’t like it, I could change it back. > > > > Katya. > > > > *From:* Eric Christopher [mailto:echri...@gmail.com] > *Sent:* Wednesday, February 10, 2016 3:16 PM > *To:* Romanova, Katya; cfe-commits@lists.llvm.org > *Subject:* Re: r260333 - This patch adds doxygen comments for all the > intrinsincs in the header file f16cintrin.h. The doxygen comments are > automatically generated based on Sony's intrinsics document. > > > > > > On Tue, Feb 9, 2016 at 4:16 PM Ekaterina Romanova via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > Author: kromanova > Date: Tue Feb 9 18:12:24 2016 > New Revision: 260333 > > URL: http://llvm.org/viewvc/llvm-project?rev=260333&view=rev > Log: > This patch adds doxygen comments for all the intrinsincs in the header > file f16cintrin.h. The doxygen comments are automatically generated based > on Sony's intrinsics document. > > -_mm_cvtph_ps(__m128i __a) > +_mm_cvtph_ps(__m128i a) > { > - return (__m128)__builtin_ia32_vcvtph2ps((__v8hi)__a); > + return (__m128)__builtin_ia32_vcvtph2ps((__v8hi)a); > } > > > > Ur? What's with this change? > > > > -eric >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
