ziangwan marked an inline comment as done. ziangwan added inline comments.
================ Comment at: clang/lib/Sema/SemaChecking.cpp:11429 + S.Context.getFloatTypeSemantics(QualType(TargetBT, 0))); + TargetFloatValue.convertFromAPInt(SourceInt, + SourceBT->isSignedInteger(), llvm::APFloat::rmNearestTiesToEven); ---------------- scanon wrote: > Why don't we just check that the result of the first conversion is opOK? I > don't think doing a round-trip check is required here. I have changed the code to check the status of the first conversion only. Please review it again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
