balazske marked an inline comment as not done. balazske added inline comments.
================ Comment at: include/clang/AST/ASTImporter.h:317 + std::shared_ptr<ASTImporterSharedState> SharedState = nullptr, + ASTUnit *Unit = nullptr); ---------------- balazske wrote: > martong wrote: > > What if we provided an additional constructor where we take over the > > ASTUnits instead of the ASTContexts? > > Then we would not need to pass the FileManagers neither. > > ``` > > ASTImporter(ASTUnit &ToUnit, > > ASTUnit &FromUnit, > > bool MinimalImport, > > std::shared_ptr<ASTImporterSharedState> SharedState = > > nullptr, > > ``` > Is the `SharedState==nullptr` case only for LLDB? If yes then it is possible > to have a "LLDB" constructor when no shared state and no ASTUnit is needed. > And another for CTU case when a From and To ASTUnit is specified and a shared > state (theoretically minimal can be true in any case but probably only true > for LLDB?). It is not trivial to make and use this new kind of constructor (with ToUnit), there is no ToUnit in the CrossTU context. Is it OK to have the original constructor, or one with `FromUnit` (but `ToContext` and `ToFileManager`)? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64554/new/ https://reviews.llvm.org/D64554 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
