[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

[Gabor Marton via Phabricator via cfe-commits]

martong added inline comments.


================
Comment at: include/clang/AST/ASTImporter.h:317
+                std::shared_ptr<ASTImporterSharedState> SharedState = nullptr,
+                ASTUnit *Unit = nullptr);
 
----------------
What if we provided an additional constructor where we take over the ASTUnits 
instead of the ASTContexts?
Then we would not need to pass the FileManagers neither.
```
    ASTImporter(ASTUnit &ToUnit, 
                ASTUnit &FromUnit,
                bool MinimalImport,
                std::shared_ptr<ASTImporterSharedState> SharedState = nullptr,
```


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64554/new/

https://reviews.llvm.org/D64554



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits