mclow.lists marked 2 inline comments as done.
mclow.lists added inline comments.


================
Comment at: libcxx/include/bit:208
+    const unsigned int __dig = numeric_limits<_Tp>::digits;
+    return (__cnt % __dig) == 0
+        ? __t
----------------
EricWF wrote:
> Why did you choose to use the ternary operator here, but you use an `if` in 
> `rotr`?
Because Arthur suggested it, and said "Meh".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D51262/new/

https://reviews.llvm.org/D51262



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to