alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land.
That's a quite impressive amount of work. Thanks! Looks good. In D62125#1508113 <https://reviews.llvm.org/D62125#1508113>, @JonasToth wrote: > Wow, a lot of work! > > I did not check all test files, but I saw that you explicitly enabled > c++11,14,17 but not 98. Is there a reason for that? I think we should test > that standard too. Having seen the amount of work out into this I wouldn't demand c++98 coverage from Dimitri. It's a huge improvement already and c++98 coverage is a rather niche thing there days. I believe, someone with genuine need for C++98 support can work on that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62125/new/ https://reviews.llvm.org/D62125 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
