vsk added inline comments.

================
Comment at: lib/CodeGen/CGObjCMac.cpp:6039
+    LT = llvm::GlobalValue::PrivateLinkage;
+  }
+
----------------
I see some minor variant of this logic repeated a few times. Wdyt of defining a 
'getLinkageTypeForObjCMetadata(CGM, Section)' helper to consolidate it in one 
place?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61454/new/

https://reviews.llvm.org/D61454



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to