aaron.ballman added a comment.

In D61239#1486692 <https://reviews.llvm.org/D61239#1486692>, @JornVernee wrote:

> In D61239#1486634 <https://reviews.llvm.org/D61239#1486634>, @aaron.ballman 
> wrote:
>
> > LGTM, thank you! That's strange that clang-format would remove the newline 
> > from the end of the file. I don't get that behavior when I try it, so it 
> > makes me wonder what's different.
>
>
> Yeah, my mistake. It was there after all. The output from clang-format looked 
> the same as what I had before, but I think I just didn't catch the newline 
> when copy-pasting the diff the first time :)


Ah that makes more sense, phew!

> Also, I don't have committer access. Would you mind committing this?

Happy to do so -- I'll try to get it in this week if I have the time, but it 
may not happen until early next week.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61239/new/

https://reviews.llvm.org/D61239



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to