aaron.ballman added a comment.

In D61239#1485994 <https://reviews.llvm.org/D61239#1485994>, @JornVernee wrote:

> - holding of on adding helper method until hearing back.


My rationale for wanting a helper method is because we already have two places 
were incompleteness is important but has special cases. It's easier to maintain 
that with something that's a named function to explain what the predicate is 
actually doing. My concern is that we add another `isIncompleteType()` and not 
think about this issue.

Do we need this in `validateFieldParentType()`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61239/new/

https://reviews.llvm.org/D61239



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to