gribozavr added inline comments.
================ Comment at: unittests/AST/OMPStructuredBlockTest.cpp:64 +++i; +})"; + ASSERT_TRUE( ---------------- lebedev.ri wrote: > gribozavr wrote: > > Same comment as in the other patch -- I would prefer that the source is > > inlined into the ASSERT_TRUE, with implicit string concatenation and "\n"s, > > if raw strings don't work. > I still don't understand the reasoning here. > It feels like a change just for the sake of the change. These variables don't improve readability. Also, if there are multiple such variables in one test, it is easy to mistakenly use an incorrect one in the ASSERT_TRUE line. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59214/new/ https://reviews.llvm.org/D59214 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
