erik.pilkington marked an inline comment as done.
erik.pilkington added inline comments.
================
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2921
+ atomicPHI->addIncoming(old, curBlock);
+ Builder.CreateCondBr(success, contBB, atomicOpBB);
Builder.SetInsertPoint(contBB);
----------------
ahatanak wrote:
> Would passing `atomicPHI->getParent()` instead of `opBB` to
> `Builder.CreateCondBr` fix the crash?
Yeah, `atomicOpBB` and `atomicPHI->getParent()` should always be equal here.
I'll update the patch to use this, since there is one less variable to keep
track of.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58744/new/
https://reviews.llvm.org/D58744
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
