ahatanak added inline comments.

================
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2921
+    atomicPHI->addIncoming(old, curBlock);
+    Builder.CreateCondBr(success, contBB, atomicOpBB);
     Builder.SetInsertPoint(contBB);
----------------
Would passing `atomicPHI->getParent()` instead of `opBB` to 
`Builder.CreateCondBr` fix the crash?


================
Comment at: clang/test/CodeGen/sanitize-atomic-int-overflow.c:3
+
+_Atomic(unsigned) atomic;
+
----------------
It's probably better to add some check strings here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58744/new/

https://reviews.llvm.org/D58744



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to