lebedev.ri added a comment. In D58284#1399443 <https://reviews.llvm.org/D58284#1399443>, @smeenai wrote:
> CC @lebedev.ri, since I believe you raised some issues during the > corresponding LLVM change but those were addressed. Yeah, i don't think i have any comments here. The logic to pick the default of `LLVM_ENABLE_IDE` (based on the existence of `CMAKE_CONFIGURATION_TYPES`) seems hacky, but it indeed does not currently detect QtCreator's CMake integration as "IDE", so i don't have any additional concerns, this looks like a straight-forward cleanup. What i do have concerns about, is that `LLVM_ENABLE_IDE` is not documented in https://llvm.org/docs/CMake.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58284/new/ https://reviews.llvm.org/D58284 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
