hokein added a comment. The code looks good. For this protocol extension, we need supports from other LSP clients, I think we may want to propose this extension to the LSP specification, so that all LSP servers/clients respect it.
================ Comment at: clangd/Protocol.h:377 + + /// Supported encodings for LSP character offsets. (clangd extension). + llvm::Optional<std::vector<OffsetEncoding>> offsetEncoding; ---------------- nit: also mention this is in preferred order. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58275/new/ https://reviews.llvm.org/D58275 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
