ilya-biryukov added inline comments.
================ Comment at: clangd/GlobalCompilationDatabase.cpp:24 +void AdjustArguments(tooling::CompileCommand &Cmd, + const std::string &ResourceDir) { + // Strip plugin related command line arguments. Clangd does ---------------- kadircet wrote: > ilya-biryukov wrote: > > NIT: use `StringRef` > Need a string for the concatenation below, when pushing to vector. Otherwise > we get a Twine Why not call `.str()` on a Twine? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56841/new/ https://reviews.llvm.org/D56841 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits