ilya-biryukov added a comment.
just a few nits
================
Comment at: clangd/GlobalCompilationDatabase.cpp:23
+
+void AdjustArguments(tooling::CompileCommand &Cmd,
+ const std::string &ResourceDir) {
----------------
naming NIT: use `adjustArguments`
================
Comment at: clangd/GlobalCompilationDatabase.cpp:24
+void AdjustArguments(tooling::CompileCommand &Cmd,
+ const std::string &ResourceDir) {
+ // Strip plugin related command line arguments. Clangd does
----------------
NIT: use `StringRef`
================
Comment at: clangd/GlobalCompilationDatabase.cpp:136
+ : Base(Base),
+ ResourceDir(ResourceDir ? *ResourceDir : getStandardResourceDir()),
+ FallbackFlags(std::move(FallbackFlags)) {
----------------
NIT: avoid an unnecessary copy: `ResourceDir ? std::move(*ResourceDir) : …`
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56841/new/
https://reviews.llvm.org/D56841
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
