aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
With bracket and comment changes, LGTM. No need for tests on this one because the scenario changed can only occur during debugging. ================ Comment at: lib/AST/ASTDumper.cpp:636 + // Since NumParams comes from the FunctionProtoType of the + // FunctionDecl and the Params are set later, it is possible ---------------- Re-flow comments to 80-col. ================ Comment at: lib/AST/ASTDumper.cpp:642 + if (!D->param_empty() && !D->param_begin()) + OS << " <<NULL params x " << D->getNumParams() << ">>"; + ---------------- Let's make this `<<<NULL params x blah>>>` with three brackets instead of two. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56753/new/ https://reviews.llvm.org/D56753 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
