dankm marked 4 inline comments as done. dankm added a comment. In D49466#1354468 <https://reviews.llvm.org/D49466#1354468>, @Lekensteyn wrote:
> Could you add more tests to check the error message for bad options (missing > `=`): > > -fdebug-prefix-map=bad > -fmacro-prefix-map=bad > -ffile-prefix-map=bad > Some more got added with the latest diff > FWIW, GCC emits two errors for `-ffile-prefix-map=bad`. Yes, this does too. It looked odd to me, but it's not a huge deal. > Another edge case is `-ffile-prefix-map==foo/`, GCC currently uses this to > prepend `foo/` to every path. Not sure if that is intentional, but that is > the current behavior (one which is also replicated by this patch I believe). Yes, with this patch it does that for file-prefix-map and macro-prefix-map. It already did that (sort-of) for debug-prefix-map, but seems to add it twice for some debugging information, but I'll fix that later since it's done that since at least version 5.0. > Could you also mark review comments that are completed as "done"? It should > make the diff easier to read (I hope) :) Yes, I tried to do that with this comment. I'm new to phabricator. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
