nickdesaulniers marked 2 inline comments as done.
nickdesaulniers added inline comments.


================
Comment at: test/Sema/alias-unused.c:3
+// expected-no-diagnostics
+int f() { return 42; }
+int g() __attribute__((alias("f")));
----------------
rjmccall wrote:
> nickdesaulniers wrote:
> > rjmccall wrote:
> > > Is this meant to be `static`?
> > It doesn't make a difference for this test.  Would you like me to add it 
> > before submitting?
> It's what you're trying to test, right?  `f()` is not otherwise an internal 
> declaration, so of course the warning won't fire for it.
sorry, you're right.  (I was testing with my locally patched version of clang, 
godbolt to the rescue to test "pre-my-change-clang." Done.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54188/new/

https://reviews.llvm.org/D54188



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to