rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.

I don't like having a solution that doesn't work for C++ and can't reasonably 
be extended to a solution for C++ (we really don't want to be demangling the 
alias target here and trying to match it against the program, and ideally we 
don't want to delay the warning in question to codegen time), but this does 
reduce warning false-positives so it seems hard to object to. (We'll still need 
to tell people to mark declarations as `__attribute__((used))` when they're 
used in this way if their names are mangled.)

On balance I'm OK with this, but adding @rjmccall in case he has a different 
view or sees a better approach.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54188/new/

https://reviews.llvm.org/D54188



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to