lebedev.ri added a comment. In https://reviews.llvm.org/D52670#1268572, @aaron.ballman wrote:
> In https://reviews.llvm.org/D52670#1268569, @lebedev.ri wrote: > > > In https://reviews.llvm.org/D52670#1268564, @aaron.ballman wrote: > > > > > I talked to someone at CERT responsible for maintaining DCL16-C to get > > > their opinion on tightening the wording of the rule and their stated > > > intent is: > > > > > > Thank you! > > > > > "If the first character is 'ell', it should be capitalized. The other > > > ells need not be, and the yew's need not be capitalized either." > > > > > > e.g., > > > 11lu -> diagnose > > > 11ul -> fine > > > 11llu -> diagnose > > > 11lLu -> diagnose > > > 11Llu -> fine > > > 11ul -> fine > > > > > > That said, the author (and I) agree that it'd be perfectly okay to > > > diagnose things like `11Llu` and recommend `11LLU` as a replacement. > > > > Ok, nothing unexpected. > > So the full revised list is: "L;LL:LU;LLU". > > > Agreed. It might be reasonable to add the above as some extra test cases for > the CERT check if they're not already covered elsewhere. Those exist as the test cases for CERT (although, i only test the integer case for CERT, not float.), i will only need to adjust the expected output. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52670 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
