aaron.ballman added a comment.

I like the thrust of this check, but we already have the 
readability-magic-numbers check and I think that this functionality would fit 
naturally there. That check finds numerical constants and recommends turning 
them into named constants, but for special values it seems reasonable to 
recommend using `numeric_limits` instead. What do others think of that, from an 
organizational perspective?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52892



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to