[PATCH] D52892: [Clang-tidy] readability check to convert numerical constants to std::numeric_limits

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added inline comments.


================
Comment at: clang-tidy/readability/NumericalCostantsToMaxIntCheck.cpp:62
+    CompilerInstance &Compiler) {
+  if (this->getLangOpts().CPlusPlus) {
+    Compiler.getPreprocessor().addPPCallbacks(
----------------
JonasToth wrote:
> you dont need `this->` and please use the same return early pattern as in the 
> other registering call
By the word, see PR32774 for such check suggestion.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52892



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits