ilya-biryukov added a comment. ilya-biryukov added inline comments.
================ Comment at: lib/Sema/CodeCompleteConsumer.cpp:622 + case CodeCompletionString::CK_Optional: + break; ---------------- This change is really sneaky and unrelated to the rest of the patch. It should definitely be done separately from this patch. Could you give more details on what fails exactly instead? Can we update the test instead? Repository: rC Clang https://reviews.llvm.org/D51038 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits