ilya-biryukov added inline comments.
================
Comment at: include/clang/Parse/Parser.h:217
+ /// Gets set to true after calling ProduceSignaturehelp, it is for a
+ /// workaround to make sure ProduceSignatureHelp is only called at the
deepest
----------------
s/ProduceSignaturehelp/ProduceSignatureHelp
================
Comment at: lib/Parse/ParseDecl.cpp:2325
+ if (ThisVarDecl && PP.isCodeCompletionReached())
+ ConstructorCompleter(true);
Actions.ActOnInitializerError(ThisDecl);
----------------
Maybe call signature help here directly and remove param from lamdba?
Having a parameter in lambda adds both makes the lamdba body more complicated
and adds extra state that we have to reason about.
Same for the other calls.
Repository:
rC Clang
https://reviews.llvm.org/D51038
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
