JonasToth added inline comments.
================ Comment at: clang-tidy/abseil/NoInternalDepsCheck.cpp:24 + + Finder->addMatcher( + nestedNameSpecifierLoc(loc(specifiesNamespace(namespaceDecl( ---------------- hugoeg wrote: > JonasToth wrote: > > Actually that one is generally useful. Accessing the `foo::internal` from > > outside of `foo` is always a problem. Maybe this matcher can become > > configurable or just match on any `internal` access from outside the > > enclosing namespace. > That's a good idea. While we agree, right now our efforts are focused on > releasing abseil specific functions. Perhaps we can refactor this check at a > later time. Ok. Could you please add a `TODO` or `FIXME` that it is not forgotten? https://reviews.llvm.org/D50542 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
