================ Comment at: lib/Parse/ParseDecl.cpp:4438 @@ -4432,1 +4437,3 @@ + // C++TS1 concept + case tok::kw_concept: ---------------- nwilson wrote: > hubert.reinterpretcast wrote: > > I'm not sure what C++TS1 is meant to refer to since the Concepts TS is not > > TS1. > I'll fix that. Any preference on a comment? C++14 Concepts-ts? ``` // C++ Concepts TS - concept ``` would work.
================ Comment at: test/Parser/cxx-concepts-value-function.cpp:11 @@ +10,3 @@ + +#ifdef DIAG + ---------------- nwilson wrote: > hubert.reinterpretcast wrote: > > hubert.reinterpretcast wrote: > > > -DDIAG=0 would still trigger the #ifdef DIAG here (which explains why the > > > test file might pass with expected-no-diagnostics). > > I meant //without// `expected-no-diagnostics` somewhere. > Hmm, yeah, I missed that and thought it was working. Is there a better way to > use/suppress the diagnostic cases? `#if DIAG` instead of `#ifdef` would work. I guess `expected-no-diagnostics` could be in the `#else` for that. http://reviews.llvm.org/D10528 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
