Re: [Catalyst] setup_home() bug

Ashley Fri, 20 Jul 2007 15:33:00 -0700

Great, you rule. Sorry about the wrap; Mail.app is full of unpleasant surprises lately. I'll try them as attachments this time.

--- Catalyst/Engine/CGI.pm.orig 2007-07-18 16:57:09.000000000 -0700
+++ Catalyst/Engine/CGI.pm      2007-07-18 16:57:24.000000000 -0700
@@ -115,7 +115,7 @@
     my $base_path;
     if ( exists $ENV{REDIRECT_URL} ) {
         $base_path = $ENV{REDIRECT_URL};
-        $base_path =~ s/$ENV{PATH_INFO}$//;
+        $base_path =~ s/\Q$ENV{PATH_INFO}\E$//;
     }
     else {
         $base_path = $ENV{SCRIPT_NAME} || '/';

live_engine_uri_for.t
Description: Binary data


On Jul 20, 2007, at 2:47 PM, Jonathan T. Rockway wrote:

On Mon, Jul 09, 2007 at 04:53:18PM -0400, Adam Herzog wrote:

 Okay. I added Catalyst::Utils::env_value(), and updated Catalyst.pm
 Index: t/unit_utils_env_value.t
 Index: lib/Catalyst.pm
 Index: lib/Catalyst/Utils.pm


Thanks for the patch, it looks great.  The only problem is that your
mail client seems to have wrapped some long lines, and even when I
manually fix it C<patch> is unable to apply the patch.

If you could regenerate and send it unmunged, then I'll get this
applied ASAP.

Regards,
Jonathan Rockway

_______________________________________________
List: [email protected]
Listinfo: http://lists.rawmode.org/mailman/listinfo/catalyst

Searchable archive: http://www.mail-archive.com/ [email protected]/

Dev site: http://dev.catalyst.perl.org/

_______________________________________________
List: [email protected]
Listinfo: http://lists.rawmode.org/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/[email protected]/
Dev site: http://dev.catalyst.perl.org/

Re: [Catalyst] setup_home() bug

Reply via email to