On Sun, Jul 08, 2007 at 03:01:55PM -0400, Adam Herzog wrote:
> I think I stumbled across a silly bug in setup_home(), when trying to
> set the home directory via an ENV var for an application named
> something like 'MyApp::Web' instead of just 'MyApp'. It would look
> for the existence of MYAPP::WEB_HOME, but then try to set the home
> directory from MYAPP_WEB_HOME. The patch changes it to always look
> for and use MYAPP_WEB_HOME.
>
> Here's the output from an svn diff, against trunk. It's a very minor
> change, but I know patches have a better chance of being applied if
> they include tests so I included a test file, as well. :) I didn't
> see any existing tests for setup_home, so I created a new unit_core
> file... let me know if I should have put the tests somewhere else
> better.
Patch looks fantastic, but it strongly suggests what we really need is an
addition to Catalyst::Utils called if_env_exists (or equivalent better name :)
What do you think? Fancy having a go at cleaning this up once and for all?
--
Matt S Trout Need help with your Catalyst or DBIx::Class project?
Technical Director Want a managed development or deployment platform?
Shadowcat Systems Ltd. Contact mst (at) shadowcatsystems.co.uk for a quote
http://chainsawblues.vox.com/ http://www.shadowcatsystems.co.uk/
_______________________________________________
List: [email protected]
Listinfo: http://lists.rawmode.org/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/[email protected]/
Dev site: http://dev.catalyst.perl.org/
