My apologies, guys. I was fairly sure that I was working with the most recent
rev, and undoing of someone else's code was completely unintentional.
As for the whitespace / tabs, its just a bad habit to 'clean up' code
when I see it.
I didnt know it would actually break future patches, so I wont do
that. Or at least
not mixed in with other actual code changes.
- mm_202.
On Sun, Jun 22, 2008 at 8:41 AM, Steve Underwood <[EMAIL PROTECTED]> wrote:
> Konstantinos Arvanitis wrote:
>> Upon looking at the changes introduced by changeset 4956 and 4963 I
>> have noticed the following:
>>
>> The changes introduced in the 4797 changeset ("application/sdp;
>> charset=utf-8") have been reverted. Was this intentional? The code as
>> changed appears to choke again on the header with a charset tag.
>>
>> A search/replace has introduced an error in a debug line output, in
>> chan_sip.c:3619. The string "update_call_cupdate_call_counterounter"
>> should obviously be "update_call_counter".
>>
>> (Personal pet-pieve) Too many lines have simple whitespace changes.
>> These would be best staged as a separate changeset marked as a simple
>> whitespace change.
>>
> The changes committed as 4956 by mm_202 seem have been messed up. They
> clean up a number of messy bits in chan_sip, but it looks like they were
> not based on properly update code from SVN.
>
> Please everyone, remember that SVN is a piece of crap, that makes no
> attempt to prevent people messing up each other's changes. It is *vital*
> to do and "svn update" immediately before you commit, so any conflicts
> in the changes you have prepared can be seen. There will always be a
> window of opportunity for troubles in the period between svn update and
> your commit. However, a failure to get things in line before a commit
> should be considered a spanking offence.
>
> Steve
>
> _______________________________________________
> Callweaver-dev mailing list
> [email protected]
> http://lists.callweaver.org/mailman/listinfo/callweaver-dev
>
_______________________________________________
Callweaver-dev mailing list
[email protected]
http://lists.callweaver.org/mailman/listinfo/callweaver-dev
