>> A dialtone signal is the best the Meridian can do with the hardware I >> have. I discovered the dialtone workaround in Cisco documentation. >> > Actually, a Merdian can be configured to do a wide range of things. > Figuring out just how can be the problem. :-)
I'll agree that figuring out how can be a problem. The phone service company told me there was nothing. I turned to the Internet and found the dialtone method. There are analog station modules for the Meridian that do better, I just don't have one. Part of my interest in Asterisk/Callweaver is related to replacing that Meridian. > If you look through dsp.c you will see that DSP_TONE_STATE_DIALTONE is > generated when dial tone is detected. If these events are being > processed, and this one occurs after disconnect, I think things will get > confused. OK, I see that __opbx_dsp_call_progress sets the state on the module local struct refered to as dsp. I observe, in the version I have, that some of the other states are reported back to the caller of __opbx_dsp_call_progress in the return parameter, like this, for example: res = OPBX_CONTROL_HANGUP I think DIALTONE is ignored. Perhaps a work in progress. >> > Evidence would be things like it already using the DTMF detector in > spandsp, and some of the other tone processing. :-) >> it occur in the channel drivers instead? Perhaps in chan_zap.c, for >> example. Or is dsp.c intended to be the interface to spandsp? >> > The channel drivers will use spandsp directly when things are finished. >> goertzel_ comes from spandsp and I see your name in spandsp.h. I guess >> it >> is too late to add a prefix to spandsp exports such as >> spandsp_goertzel_. >> > Why would you want to do that? So when reading the code it is easier to determine the relationship of the function to the local module and the project as a whole. spandsp is a library external to callweaver. I initially assumed the goertzel functions were local to dsp.c because of the absence of a prefix, especially considering the presence of prefixes such as opbx_dsp_ which gives a sense of context. I had no idea what goertzel is from the name - presumably I would if I had a background in signal processing. > If you need something quick, I think you should just try to fudge it for > now. There is a better call progress tone detector in spandsp than the > one in dsp.c, but it still isn't great. The great one is in progress. > :-) I think I'm getting a little free time to work on it again, now, so > it should be done soon. I look forward to it. I'll sit on my patch. I'll probably enhance to detect dial tone using the method employed in __opbx_dsp_call_progress, but outside the context of call_progress. _______________________________________________ Callweaver-dev mailing list [email protected] http://lists.callweaver.org/mailman/listinfo/callweaver-dev
