----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124927/#review84386 -----------------------------------------------------------
Sounds like the applix filter got broken then :-( - Boudewijn Rempt On Aug. 26, 2015, 12:03 a.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124927/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2015, 12:03 a.m.) > > > Review request for Calligra and David Faure. > > > Repository: calligra > > > Description > ------- > > The sources files of the Applix* import filters had been stored in > iso8859-15. In the methods to convert characters from Applix-style encoding > to a QChar the mapping was done by assigning respective `char`s to a QChar, > with the `char`s mostly being in the upper half of the iso8859-15 table. > Not sure if this ever worked in Qt4 (perhaps worked with older Qt), at least > the docu does not really tell what decoder is used for the `QChar(char ch)` > constructor. > > So this patch converts the source files to UTF-8 and also changes the values > used for mapping to the Unicode code point code. Compiles at leas here :) And > my sample aw files still are imported with same quality as before. Just, they > all seem to lack any non-latin1 characters, so I cannot test how the filters > changed to . Experimented with manual editing of the raw aw files, but not > sure if I fooled myself, so would prefer real files. > > David, you are the only one known with access to ApplixWords/ApplixSpread, > could you tell if this patch improves or breaks things? > (The .aw files created with AbiWord for tests sadly seem all to be imported > as empty documents always, no idea why) > > > Diffs > ----- > > filters/sheets/applixspread/applixspreadimport.cc d3db02a > filters/words/applixword/applixwordimport.cc c890cfa > > Diff: https://git.reviewboard.kde.org/r/124927/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
