> On Feb. 18, 2015, 2:30 p.m., Jarosław Staniek wrote: > > kexi/main/KexiMainWindow.cpp, line 3738 > > <https://git.reviewboard.kde.org/r/122559/diff/1-2/?file=348657#file348657line3738> > > > > useTempQuery != 0 > > > > (cleaner, since useTempQuery isn't a bool) > > Roman Shtemberko wrote: > Do you mean "prevWindowId != 0" ?
yep - Jarosław ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122559/#review76223 ----------------------------------------------------------- On Feb. 19, 2015, 12:42 p.m., Roman Shtemberko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122559/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2015, 12:42 p.m.) > > > Review request for Calligra, Adam Pigg, Jarosław Staniek, Radosław Wicik, and > Wojciech Kosowicz. > > > Repository: calligra > > > Description > ------- > > Message is being displayed If design of query being exported is dirty. Also > window with query is opened (without switching views) on export. > > > Diffs > ----- > > kexi/plugins/queries/kexiquerypart.h 09491f5 > kexi/plugins/queries/kexiquerypart.cpp ce7548e > kexi/core/KexiMainWindowIface.h 2798198 > kexi/core/kexipart.h e320434 > kexi/core/kexipart.cpp ca70942 > kexi/main/KexiMainWindow.h 628fb22 > kexi/main/KexiMainWindow.cpp 3ae1eac > kexi/migration/importtablewizard.cpp 632fed8 > kexi/plugins/importexport/csv/CMakeLists.txt 9d40ce6 > kexi/plugins/importexport/csv/kexicsvexport.h 280b33f > kexi/plugins/importexport/csv/kexicsvexport.cpp dfe107d > kexi/plugins/importexport/csv/kexicsvexportwizard.cpp 096ea71 > > Diff: https://git.reviewboard.kde.org/r/122559/diff/ > > > Testing > ------- > > Work with both exports (to file/clipboard). > > > Thanks, > > Roman Shtemberko > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
