----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122559/#review75993 -----------------------------------------------------------
kexi/core/KexiMainWindowIface.h <https://git.reviewboard.kde.org/r/122559/#comment52423> Please duplicate the docs for each method separately. kexi/core/KexiMainWindowIface.h <https://git.reviewboard.kde.org/r/122559/#comment52422> const int & -> int int is a plain old type (POD) kexi/main/KexiMainWindow.cpp <https://git.reviewboard.kde.org/r/122559/#comment52431> This is not implemented so let's keep it: //! @todo: accept record changes... kexi/main/KexiMainWindow.cpp <https://git.reviewboard.kde.org/r/122559/#comment52440> 1. The very same method can be called for items of partClass of tables. So please check if its partClass indicates that it's a query. 2. What to do in case of tables? I guess tables cannot be dirty in data view. If they are in design mode and dirty, we need separate message. 3. Another case: what if query is dirty never saved? For now the action is disabled but why should it be - http://i.imgur.com/YL7hD0J.png? (BTW, table cannot be dirty and never saved) kexi/main/KexiMainWindow.cpp <https://git.reviewboard.kde.org/r/122559/#comment52436> Why do we open if it's not opened at all? (we know it cannot be dirty then) We only want to activate the tab, using activateWindow(int id) kexi/main/KexiMainWindow.cpp <https://git.reviewboard.kde.org/r/122559/#comment52438> let's propagate real answer which is here: cancelled ==> user wants to cancel the whole export thing kexi/main/KexiMainWindow.cpp <https://git.reviewboard.kde.org/r/122559/#comment52439> more clear: "useTemp" -> "useOriginalQuery" kexi/main/KexiMainWindow.cpp <https://git.reviewboard.kde.org/r/122559/#comment52437> changedQueryDlg -> askOnExportingChangedQuery kexi/main/KexiMainWindow.cpp <https://git.reviewboard.kde.org/r/122559/#comment52424> i18nc("@info", "......") notation needed here http://techbase.kde.org/Development/Tutorials/Localization/i18n_Semantics kexi/main/KexiMainWindow.cpp <https://git.reviewboard.kde.org/r/122559/#comment52429> i18n( -> i18nc("Export query data", kexi/main/KexiMainWindow.cpp <https://git.reviewboard.kde.org/r/122559/#comment52430> i18n( -> i18nc("Export query data", kexi/main/KexiMainWindow.cpp <https://git.reviewboard.kde.org/r/122559/#comment52428> this is the default, so not needed kexi/main/KexiMainWindow.cpp <https://git.reviewboard.kde.org/r/122559/#comment52427> true is enough, autocasts kexi/main/KexiMainWindow.cpp <https://git.reviewboard.kde.org/r/122559/#comment52425> false is enough, autocasts kexi/main/KexiMainWindow.cpp <https://git.reviewboard.kde.org/r/122559/#comment52426> cancelled is enough, autocasts kexi/main/KexiMainWindow.cpp <https://git.reviewboard.kde.org/r/122559/#comment52442> New code in this method is largely the same as in exportItemAsDataTable(). Please extract common private method. kexi/plugins/importexport/csv/kexicsvexport.h <https://git.reviewboard.kde.org/r/122559/#comment52443> change name accordingly as explained above kexi/plugins/importexport/csv/kexicsvexportwizard.cpp <https://git.reviewboard.kde.org/r/122559/#comment52444> This shouldn't work, look at the cmake file, we don't link to the query plugin. Instead please let's add QuerySchema* KexiMainWindowIface::unsavedQuery(queryId) and use it in line 91 with arg m_options.itemId. The new method should return 0 if the query with name <name> isn't opened or is't unsaved (dirty). libs/db/utils.h <https://git.reviewboard.kde.org/r/122559/#comment52446> please also add setTable() then libs/db/utils.h <https://git.reviewboard.kde.org/r/122559/#comment52445> m_table has to be cleared here - Jarosław Staniek On Feb. 13, 2015, 2:49 p.m., Roman Shtemberko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122559/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2015, 2:49 p.m.) > > > Review request for Calligra, Adam Pigg, Jarosław Staniek, Radosław Wicik, and > Wojciech Kosowicz. > > > Repository: calligra > > > Description > ------- > > Message is being displayed If design of query being exported is dirty. Also > window with query is opened (without switching views) on export. > > > Diffs > ----- > > libs/db/utils.h 9c88d14 > kexi/plugins/importexport/csv/kexicsvexportwizard.cpp 096ea71 > kexi/core/KexiMainWindowIface.h 2798198 > kexi/main/KexiMainWindow.h 628fb22 > kexi/main/KexiMainWindow.cpp e82b49e > kexi/plugins/importexport/csv/CMakeLists.txt 9d40ce6 > kexi/plugins/importexport/csv/kexicsvexport.h 280b33f > kexi/plugins/importexport/csv/kexicsvexport.cpp dfe107d > > Diff: https://git.reviewboard.kde.org/r/122559/diff/ > > > Testing > ------- > > Work with both exports (to file/clipboard). > > > Thanks, > > Roman Shtemberko > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
