> On Jan. 19, 2015, 12:10 p.m., Friedrich W. H. Kossebau wrote:
> > krita/ui/opengl/kis_opengl_canvas2_p.h, line 38
> > <https://git.reviewboard.kde.org/r/122115/diff/1/?file=342473#file342473line38>
> >
> > "// RJVB" is not a perfect comment ;) Please add here a comment why
> > this is done.
> >
> > In the RR you say:
> > "typedef void* GLsync: in order not to impose a required dependency on
> > GLEW."
> > How exactly does that work? Because for me it breaks compilation on a
> > system wher GLEW is not installed. Can we please fix this?
What are your symptoms on a system without GLEW?
Problems is I cannot currently allocate the resources to do a full Krita build
(I lost my build tree), so experimenting will have to wait.
The way this worked for me before I installed MacPorts glew is that it provides
a type normally defined in gltypes.h and that is expected to be available even
if you don't have glew.
Or at least that was the case a couple months back when I introduced this
change, but it still seems to be true (cf. line 316 in the same header file).
What I can propose (and what you can commit if you're in a hurry) is to do this:
```
#if defined(Q_OS_MAC) && !defined(HAVE_GLEW)
// provide the GLsync type even if GLEW is not available
typedef void* GLsync;
#endif
```
- René J.V.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122115/#review74305
-----------------------------------------------------------
On Jan. 18, 2015, 5:09 p.m., René J.V. Bertin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122115/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2015, 5:09 p.m.)
>
>
> Review request for Calligra and KDE Software on Mac OS X.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> This patch is a companion to the build system adaptations from RR
> 122114(https://git.reviewboard.kde.org/r/122114/), and includes a number of
> adaptations to OS X peculiarities.
>
> In order of appearance in the patch file:
> - OS X has a so-called `application menu` which has a number of standard
> `menu items` (actions in Qt speak): About, Preferences and Quit. Qt tries to
> guess which actions are to be assigned to these menu items, in a 1st come,
> 1st served fashion and using text-based heuristics on the action text. This
> works reliably enough for Quit, but not so for the About and Preferences
> items which both tend to have multiple matches in KDE menus. For this reason
> it is good practice to `setMenuRole` on the relevant actions when they are
> created.
> - `typedef void* GLsync`: in order not to impose a required dependency on
> GLEW.
> - KDE applications commonly use the `.so` extension for shared modules and
> plugins, and the build system creates them that way.
>
>
> Diffs
> -----
>
> flow/part/FlowView.cpp 5ce755f
> karbon/ui/KarbonView.cpp db71464
> krita/ui/opengl/kis_opengl_canvas2_p.h 16ba118
> libs/db/drivers/sqlite/sqliteconnection.cpp 23a6eca
> libs/kopageapp/KoPAView.cpp fa0e381
> words/part/KWView.cpp 9f2f230
>
> Diff: https://git.reviewboard.kde.org/r/122115/diff/
>
>
> Testing
> -------
>
> On OS X 10.9.5 with kdelibs 4.14.4 and Qt 4.8.6, on a mid 2011 13" Macbook
> Pro (2.7Ghz dual-core i7, Intel HD3000 graphics)
>
>
> Thanks,
>
> René J.V. Bertin
>
>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
