> On Jan. 18, 2015, 4:01 a.m., Inge Wallin wrote:
> > libs/db/drivers/sqlite/sqliteconnection.cpp, line 50
> > <https://git.reviewboard.kde.org/r/122115/diff/1/?file=342474#file342474line50>
> >
> > But this define is for both plugins and actual libraries, isn't it? Is
> > this safe?
>
> René J.V. Bertin wrote:
> Given that the change is confined to a single source file (which I
> presume but haven't checked isn't included in others), I think so. I'll have
> another look, but I don't think that file loads objects that are also used
> (i.e. linked-in) as shared libraries. Or to be more explicit, shared
> libraries that are linked in with the `-lfoo` search function that on OS X
> finds `libfoo.dylib`; shared libraries that are linked in with a full path
> specification are of course not affected.
The macros is also used only in a single location:
```C++
QString icuExtensionFilename(
KStandardDirs::locate("module", QLatin1String("kexidb_sqlite3_icu"
SHARED_LIB_EXTENSION)));
```
and that module (=/= shared library) indeed has a .so extension on OS X.
- René J.V.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122115/#review74221
-----------------------------------------------------------
On Jan. 17, 2015, 11:17 p.m., René J.V. Bertin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122115/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2015, 11:17 p.m.)
>
>
> Review request for Calligra and KDE Software on Mac OS X.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> This patch is a companion to the build system adaptations from RR
> 122114(https://git.reviewboard.kde.org/r/122114/), and includes a number of
> adaptations to OS X peculiarities.
>
> In order of appearance in the patch file:
> - OS X has a so-called `application menu` which has a number of standard
> `menu items` (actions in Qt speak): About, Preferences and Quit. Qt tries to
> guess which actions are to be assigned to these menu items, in a 1st come,
> 1st served fashion and using text-based heuristics on the action text. This
> works reliably enough for Quit, but not so for the About and Preferences
> items which both tend to have multiple matches in KDE menus. For this reason
> it is good practice to `setMenuRole` on the relevant actions when they are
> created.
> - `typedef void* GLsync`: in order not to impose a required dependency on
> GLEW.
> - KDE applications commonly use the `.so` extension for shared modules and
> plugins, and the build system creates them that way.
>
>
> Diffs
> -----
>
> flow/part/FlowView.cpp 5ce755f
> karbon/ui/KarbonView.cpp db71464
> krita/ui/opengl/kis_opengl_canvas2_p.h 16ba118
> libs/db/drivers/sqlite/sqliteconnection.cpp 23a6eca
> libs/kopageapp/KoPAView.cpp fa0e381
> words/part/KWView.cpp 9f2f230
>
> Diff: https://git.reviewboard.kde.org/r/122115/diff/
>
>
> Testing
> -------
>
> On OS X 10.9.5 with kdelibs 4.14.4 and Qt 4.8.6, on a mid 2011 13" Macbook
> Pro (2.7Ghz dual-core i7, Intel HD3000 graphics)
>
>
> Thanks,
>
> René J.V. Bertin
>
>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
