> On July 1, 2013, 2:25 a.m., Inge Wallin wrote: > > No comment on the patch yet but it seems to me that you have a larger plan > > behind all of these patches. Is it just to get out of the way from other > > applications or is your ultimate goal something else? None of the other > > large KDE apps, like the Kontact suite for instance, does this as far as I > > know. And the Gnome apps definitely don't. Instead they go the other way > > and try to occupy as much namespace as possible and also preferably as > > generic as possible. Case in point: The "Document" Foundation instead of > > The LibreOffice Foundation.
No hidden plan, just wanting to make Calligra a good citizen of the FLOSS world (I tend to follow good examples, not the bad ones ;) ) And see the arguments I gave above, for me it's basically also about having it easier to do the cat-herding of our plugins/libs/headers as developer. (And to increase the K in your AFAIK, kdepim (thus Kontact) installs to akonadi/, kcal/, kabc/, kmime/ etc. Marble installs to marble/. And others similar. Which is a Good Thing (tm) IMHO :) No idea about other apps (using other toolkits), they might have to learn the hard way that this is not a smart way to go, unless by purpose to do evil to the rest of the gang. But then I expect Good Will from FLOSS projects in general :) So please if you see any non-namespaced headers, by prefix or subdir, which can result in conflicts, file a bug report with that project. Or file the bug via your distribution, they should share the interest) For names of companies/foundations/states I do not care here :) - Friedrich W. H. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111326/#review35334 ----------------------------------------------------------- On June 30, 2013, 9:38 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111326/ > ----------------------------------------------------------- > > (Updated June 30, 2013, 9:38 p.m.) > > > Review request for Calligra. > > > Description > ------- > > While almost all headers of Calligra libs are prefixed with "Ko"/"ko" it > feels better to install them to their own subdir named "calligra/": > * Easier for people using the libs and wanting to browse through all the > available headers (until we improve > http://api.kde.org/bundled-apps-api/calligra-apidocs/) > * Easier also for developers to just remove the complete calligra/ dir to > clean up > * subdirs "styles/" & "changetracker/" are used by kotext headers, which > feels strange directly in the normal include dir, without any prefix > > Questions: > * Should that "calligra/" be made a configuration option? Who might need/want > change that to something else? > * Should all the other apps also install below calligra/$APP, or continue to > use "words/", "sheets/", "stage/" etc.? > > > Diffs > ----- > > CMakeLists.txt 2504353 > interfaces/CMakeLists.txt 36eb42a > libs/basicflakes/CMakeLists.txt 4750c5f > libs/flake/CMakeLists.txt 233d3ce > libs/kopageapp/CMakeLists.txt deb7d76 > libs/kotext/CMakeLists.txt 8929d8a > libs/kundo2/CMakeLists.txt cf66a13 > libs/main/CMakeLists.txt 147b25c > libs/odf/CMakeLists.txt 574f8a5 > libs/pigment/CMakeLists.txt 8cc00e8 > libs/rdf/CMakeLists.txt 875ce13 > libs/textlayout/CMakeLists.txt cf2b83b > libs/widgets/CMakeLists.txt 38155e7 > libs/widgetutils/CMakeLists.txt bfe64ca > > Diff: http://git.reviewboard.kde.org/r/111326/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel