----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109410/#review29010 -----------------------------------------------------------
You could consider checking if the current style has been selected through the respective commandline switch. Which would indicate a user's explicit choice. - Kevin Krammer On March 11, 2013, 9:26 a.m., Boudewijn Rempt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109410/ > ----------------------------------------------------------- > > (Updated March 11, 2013, 9:26 a.m.) > > > Review request for Calligra. > > > Description > ------- > > For Krita, with its default dark theme, only two styles work: oxygen and > plastique. Oxygen is default in KDE, if the user selects something else, it's > their problem. On windows, osx and ubuntu, the default style is broken for > krita, so hard-code plastique if the user is running krita outside KDE. > > This means that on Windows, other apps than Krita will use the default > windows style again. It might be worth it to reinstate the code that detects > the windows version and sets the right style, but that is up for discussion. > > > Diffs > ----- > > libs/main/KoApplication.cpp 87536f1 > > Diff: http://git.reviewboard.kde.org/r/109410/diff/ > > > Testing > ------- > > > Thanks, > > Boudewijn Rempt > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
