----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108096/#review28193 -----------------------------------------------------------
Ship it! Congratulations Friedrich, you resisted my nitpicking :) Perfect work. - Jarosław Staniek On Feb. 4, 2013, 10:18 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108096/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2013, 10:18 p.m.) > > > Review request for Calligra, Adam Pigg and Jarosław Staniek. > > > Description > ------- > > Reworked KoReport section editor dialogs, especially Ok/Cancel/Close dialog > buttons. Oh, and now also these: > > * base on KDialog > * put labels in front of QCheckboxes > * follow KDE UI guidelines for all text strings > * disable buttons when no-ops > * only offer columns for section grouping which are not used yet > * do not leave an empty group on clicking Cancel during process of adding a > new section group > * skip empty field/key when offering fields for grouping > * make API of ReportSectionDetail consistent (GroupSection where just Section > was used) > * removed any manually set spacings/margins, besides the 0 margins, looks > less strange now > > Better now? :) > > And okay to backport to 2.6, without the string changes? > > > Diffs > ----- > > libs/koreport/wrtembed/detailgroupsectiondialog.h df5504e > libs/koreport/wrtembed/detailgroupsectiondialog.cpp ec0c84c > libs/koreport/wrtembed/detailgroupsectiondialog.ui 32f4700 > libs/koreport/wrtembed/reportsectiondetail.h 3079d5a > libs/koreport/wrtembed/reportsectiondetail.cpp 5163611 > libs/koreport/wrtembed/reportsectiondetailgroup.h 94cebf4 > libs/koreport/wrtembed/sectioneditor.h 97a20c6 > libs/koreport/wrtembed/sectioneditor.cpp e7b9205 > libs/koreport/wrtembed/sectioneditor.ui ba9a337 > plan/libs/ui/reports/reportview.cpp dee77a6 > > Diff: http://git.reviewboard.kde.org/r/108096/diff/ > > > Testing > ------- > > Used in Kexi, works better as before. > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
