----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107598/#review23027 -----------------------------------------------------------
Please fix the remaining issues and I'll commit. kexi/plugins/forms/kexiformscrollview.cpp <http://git.reviewboard.kde.org/r/107598/#comment17597> please move initialization to initialization list of the Private constructor kexi/plugins/forms/kexiformscrollview.cpp <http://git.reviewboard.kde.org/r/107598/#comment17598> '{' in new line kexi/plugins/forms/kexiformscrollview.cpp <http://git.reviewboard.kde.org/r/107598/#comment17599> '{' in new line - Jarosław Staniek On Dec. 5, 2012, 11:48 a.m., Shou Ya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107598/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2012, 11:48 a.m.) > > > Review request for Calligra and Jarosław Staniek. > > > Description > ------- > > add d-pointer for KexiScrollView. > > This is a part of the task 'ADD D-POINTERS TO CLASSES' from Google > Code-in(https://www.google-melange.com/gci/task/view/google/gci2012/7971213). > > changed KexiScrollView class and some of its derived class KexiFormScrollView > who referred to some protected members of KexiScrollView. > > So I created some protected assessors for them. > > > Diffs > ----- > > kexi/plugins/forms/kexiformscrollview.h a7dc9d0 > kexi/plugins/forms/kexiformscrollview.cpp cad94c7 > kexi/plugins/forms/widgets/kexidbform.h c2e0eca > kexi/plugins/forms/widgets/kexidbform.cpp c2dd1c5 > kexi/widget/kexiscrollview.h 4fc6f85 > kexi/widget/kexiscrollview.cpp 5a94228 > > Diff: http://git.reviewboard.kde.org/r/107598/diff/ > > > Testing > ------- > > > Thanks, > > Shou Ya > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
