----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107598/#review23016 -----------------------------------------------------------
In the same patch please also add d-pointer to KexiFormScrollView in one go. kexi/widget/kexiscrollview.h <http://git.reviewboard.kde.org/r/107598/#comment17589> By the way, let's change to more clear: bool isPreviewing() const. kexi/widget/kexiscrollview.h <http://git.reviewboard.kde.org/r/107598/#comment17588> Please change to "const QTimer *delayedResizeTimer() const" kexi/widget/kexiscrollview.cpp <http://git.reviewboard.kde.org/r/107598/#comment17590> bug, should be preview(preview_) kexi/widget/kexiscrollview.cpp <http://git.reviewboard.kde.org/r/107598/#comment17591> please rename to scrollbarModeSet kexi/widget/kexiscrollview.cpp <http://git.reviewboard.kde.org/r/107598/#comment17586> please don't put types on separate line - this convention has been dropped, we just haven't updated the code. - Jarosław Staniek On Dec. 5, 2012, 5:55 a.m., Shou Ya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107598/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2012, 5:55 a.m.) > > > Review request for Calligra and Jarosław Staniek. > > > Description > ------- > > add d-pointer for KexiScrollView. > > This is a part of the task 'ADD D-POINTERS TO CLASSES' from Google > Code-in(https://www.google-melange.com/gci/task/view/google/gci2012/7971213). > > changed KexiScrollView class and some of its derived class KexiFormScrollView > who referred to some protected members of KexiScrollView. > > So I created some protected assessors for them. > > > Diffs > ----- > > kexi/plugins/forms/kexiformscrollview.cpp cad94c7 > kexi/widget/kexiscrollview.h 4fc6f85 > kexi/widget/kexiscrollview.cpp 5a94228 > > Diff: http://git.reviewboard.kde.org/r/107598/diff/ > > > Testing > ------- > > > Thanks, > > Shou Ya > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
