-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106633/#review21195
-----------------------------------------------------------


This review has been submitted with commit 
074d6cc1f24b5e5227263f9716258b3fd051a1de by Inge Wallin to branch 
kexi-altertable-staniek.

- Commit Hook


On Sept. 29, 2012, 6 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106633/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2012, 6 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This patch fulfills a very old wish of ours, namely the separation of the 
> stroke/fill docker into a widget and an embedding docker. This makes the 
> stroke/fill widget reusable in other places, e.g. a style manager for graphic 
> styles.
> 
> I have tried to make the user experience exactly the same as for the old 
> version even though there are lots of misfeatures with it.  Improving the 
> user experience will come as future patches, and I don't want to do that 
> without discussing it with other people.
> 
> 
> Diffs
> -----
> 
>   plugins/dockers/CMakeLists.txt c9b4f44 
>   plugins/dockers/styledocker/StrokeFillWidget.h PRE-CREATION 
>   plugins/dockers/styledocker/StrokeFillWidget.cpp PRE-CREATION 
>   plugins/dockers/styledocker/StyleDocker.h b0301e6 
>   plugins/dockers/styledocker/StyleDocker.cpp 376ffef 
> 
> Diff: http://git.reviewboard.kde.org/r/106633/diff/
> 
> 
> Testing
> -------
> 
> Extensive manual testing.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Reply via email to