----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106633/#review19598 -----------------------------------------------------------
plugins/dockers/styledocker/StrokeFillWidget.cpp <http://git.reviewboard.kde.org/r/106633/#comment15582> I think this FIXME should be removed. I think it is a nice feature that the stroke widget shows the currently selected color. plugins/dockers/styledocker/StrokeFillWidget.cpp <http://git.reviewboard.kde.org/r/106633/#comment15583> This comment seems to be wrong. plugins/dockers/styledocker/StyleDocker.h <http://git.reviewboard.kde.org/r/106633/#comment15584> I don't think moving this down makes sense. I think the base class should always be the first class to be includes in a file. - Thorsten Zachmann On Sept. 29, 2012, 2:35 p.m., Inge Wallin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106633/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2012, 2:35 p.m.) > > > Review request for Calligra. > > > Description > ------- > > This patch fulfills a very old wish of ours, namely the separation of the > stroke/fill docker into a widget and an embedding docker. This makes the > stroke/fill widget reusable in other places, e.g. a style manager for graphic > styles. > > I have tried to make the user experience exactly the same as for the old > version even though there are lots of misfeatures with it. Improving the > user experience will come as future patches, and I don't want to do that > without discussing it with other people. > > > Diffs > ----- > > plugins/dockers/CMakeLists.txt c9b4f44 > plugins/dockers/styledocker/StrokeFillWidget.h PRE-CREATION > plugins/dockers/styledocker/StrokeFillWidget.cpp PRE-CREATION > plugins/dockers/styledocker/StyleDocker.h b0301e6 > plugins/dockers/styledocker/StyleDocker.cpp 376ffef > > Diff: http://git.reviewboard.kde.org/r/106633/diff/ > > > Testing > ------- > > Extensive manual testing. > > > Thanks, > > Inge Wallin > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
