----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106040/#review17452 -----------------------------------------------------------
This review has been submitted with commit 39467187ba24763dddf312ef28549dbaa7dc5003 by Friedrich W. H. Kossebau to branch master. - Commit Hook On Aug. 15, 2012, 2:56 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106040/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2012, 2:56 p.m.) > > > Review request for Calligra. > > > Description > ------- > > Somehow the numbers in the rulers to me still looked not balanced to the rest > of the UI. Having a closer look at the code I found that the basic reason is > that while the ruler metric calculations are based on > KGlobalSettings::toolBarFont() the actual rendering does use the normal > widget font. > > Another issue I see is that KGlobalSettings::toolBarFont() is used, not > KGlobalSettings::smallestReadableFont(), which IMHO is better suited here. > And the API dox writer even agrees with me: > http://api.kde.org/4.8-api/kdelibs-apidocs/kdeui/html/classKGlobalSettings.html#a1af6d9cc0108fca58b002b4c127dc51f > "This can be used in dockers, rulers and other places where space is at a > premium." > :) > > Attached patch fixes that, both by switching to smallestReadableFont() and > setting the font before rendering the measurement numbers. > > Okay to backport to 2.5? > > > Diffs > ----- > > libs/main/KoRuler.cpp 98b096a > > Diff: http://git.reviewboard.kde.org/r/106040/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
