Ship it! -- I'm on the wrong laptop to actually do that in the reviewboard
gui, I'm afraid
On Wed, 15 Aug 2012, Friedrich W. H. Kossebau wrote:
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106040/
Review request for Calligra.
By Friedrich W. H. Kossebau.
Description
Somehow the numbers in the rulers to me still looked not balanced to the rest
of the UI. Having a cl
oser look at the code I found that the basic reason is that while the ruler metric calculations are
based on KGlobalSettings::toolBarFont() the actual rendering does use the normal widget font.
Another issue I see is that KGlobalSettings::toolBarFont() is used, not
KGlobalSettings::smallestRea
dableFont(), which IMHO is better suited here. And the API dox writer even
agrees with me:
http://api.kde.org/4.8-api/kdelibs-apidocs/kdeui/html/classKGlobalSettings.html#a1af6d9cc0108fca58b0
02b4c127dc51f
"This can be used in dockers, rulers and other places where space is at a
premium."
:)
Attached patch fixes that, both by switching to smallestReadableFont() and
setting the font before r
endering the measurement numbers.
Okay to backport to 2.5?
Diffs
* libs/main/KoRuler.cpp (98b096a)
View Diff
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
