----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105700/#review16782 -----------------------------------------------------------
This review has been submitted with commit b1bf5264e31cdab9e0b2fa74b7ae8393d6195af1 by Friedrich W. H. Kossebau to branch calligra/2.5. - Commit Hook On July 23, 2012, 9:39 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105700/ > ----------------------------------------------------------- > > (Updated July 23, 2012, 9:39 p.m.) > > > Review request for Calligra and Cyrille Berger Skott. > > > Description > ------- > > As I haven't done enough review requests today... ;) > > The tool for the webshape has still the name "State tool" (seems that was the > code origin template). > Also the option widget title "Web tool options" seems unneeded, given there > is only one option widget for the tool. Only results in UI clutter. > > Patch fixes the name to be "Web Shape Tool" and simply removes the option > title widget. > > For 2.5 I wonder if instead of backporting this patch (string change) rather > the webshape plugin should be completely disabled: > * behaves strange on zoom change of the view of the document it is contained > in > * no possibility to zoom the content of the web page independently, so not > really usable to use as kind of picture in another > > Also wondering why the web shape is a braindump plugin and not a general > Calligra one. > > > Diffs > ----- > > braindump/plugins/webshape/WebTool.cpp 3a8770a > braindump/plugins/webshape/WebToolFactory.cpp 9983b7d > > Diff: http://git.reviewboard.kde.org/r/105700/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
