----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105700/#review16735 -----------------------------------------------------------
Ship it! Please go ahead both for master and calligra/2.5 As for disabling, I had rather have it not happen, it works well enough for braindump, and if it is inconvenient for other applications, I had rather have it disabled in those than in general (and that is why it is still a braindump plugin, so that it does not get disabled/removed too quickly and hopefully without me noticing it, especially since for braindump pixel perfection is not a requirement). As for zooming, you can zoom independently of the view, with the webtool, just shift-drag. For the view zooming, I noticed a bug with the scroll offset, which I reported here: https://bugs.kde.org/show_bug.cgi?id=304368, if you experience other problems, please comment on the bug or open a new bug report. - Cyrille Berger Skott On July 23, 2012, 9:39 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105700/ > ----------------------------------------------------------- > > (Updated July 23, 2012, 9:39 p.m.) > > > Review request for Calligra and Cyrille Berger Skott. > > > Description > ------- > > As I haven't done enough review requests today... ;) > > The tool for the webshape has still the name "State tool" (seems that was the > code origin template). > Also the option widget title "Web tool options" seems unneeded, given there > is only one option widget for the tool. Only results in UI clutter. > > Patch fixes the name to be "Web Shape Tool" and simply removes the option > title widget. > > For 2.5 I wonder if instead of backporting this patch (string change) rather > the webshape plugin should be completely disabled: > * behaves strange on zoom change of the view of the document it is contained > in > * no possibility to zoom the content of the web page independently, so not > really usable to use as kind of picture in another > > Also wondering why the web shape is a braindump plugin and not a general > Calligra one. > > > Diffs > ----- > > braindump/plugins/webshape/WebTool.cpp 3a8770a > braindump/plugins/webshape/WebToolFactory.cpp 9983b7d > > Diff: http://git.reviewboard.kde.org/r/105700/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
